Skip to content

TCA-505 reduce js bundle size #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2022

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Oct 10, 2022

https://topcoder.atlassian.net/browse/TCA-505

Splits the JS bundle into multiple js chunks, and reduces the size of the js files downloaded initially (by not loading the extra modules).

@vas3a vas3a self-assigned this Oct 10, 2022
@vas3a vas3a changed the title Tca 505 reduce js bundle size TCA-505 reduce js bundle size Oct 10, 2022
Copy link
Contributor

@testflyjets testflyjets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as long as this code splitting and lazy loading approach is current and stable -- not clear to me from the React docs if that's the case. If not, let's chat.

Copy link
Contributor

@brooketopcoder brooketopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!

Can you add a Lazy-loading Components section to the '## Adding a Tool or Util' to the README?

@vas3a vas3a requested a review from brooketopcoder October 17, 2022 12:22
@vas3a
Copy link
Collaborator Author

vas3a commented Oct 17, 2022

@brooketopcoder I updated the readme.md, can you recheck? thanks!

@brooketopcoder
Copy link
Contributor

@vas3a Approved--thanks!

@brooketopcoder brooketopcoder changed the base branch from dev to TCA-483_performance October 17, 2022 18:59
@brooketopcoder brooketopcoder merged commit 369c27a into TCA-483_performance Oct 17, 2022
@brooketopcoder brooketopcoder deleted the TCA-505-reduce-js-bundle-size branch October 17, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants